ref: cf6e4e272c2aa3477f149eb75ffe0436e1a8a2b0
parent: b95812963a8d187526145f5e1a9693f10eee2b65
author: Simon Tatham <anakin@pobox.com>
date: Sun Dec 11 04:19:30 EST 2016
Correct a logic error in Unequal game desc validation. A user points out that the error check that should have detected a non-digit where a digit should have been was never firing, due to an && that should have been ||. I don't think it was a harmful error - the subsequent check that the number was in range, plus the skipping past only digits to find the next part of the string, combine to arrange that not many kinds of invalid game id could actually get through. But it did have the small effect that a 0 could be elided without triggering an error, e.g. the game ids 4:0,0,0,0,0,0L,0,0,0R,0U,0,0L,0,0,,3, 4:0,0,0,0,0,0L,0,0,0R,0U,0,0L,0,0,0,3, would both be accepted, and would be decoded into the same game, even though the former should have failed syntax validation. Now it does.
--- a/unequal.c
+++ b/unequal.c
@@ -1214,7 +1214,7 @@
why = "Too much data to fill grid"; goto fail;
}
- if (*p < '0' && *p > '9') {+ if (*p < '0' || *p > '9') {why = "Expecting number in game description"; goto fail;
}
n = atoi(p);