shithub: puzzles

Download patch

ref: 197e262ba643a7c0af7f157ae175445109b7d132
parent: 877900f58af023be317ee79b7ed29f13b1e9f18e
author: Simon Tatham <anakin@pobox.com>
date: Sat May 20 07:54:21 EDT 2006 

Cleanup patch from Ben Hutchings, fixing some odd-looking range
checks. He thinks they were harmless (due to being followed by other
range checks in RIGHTOF_DOT and friends) but it clearly can't hurt
to fix them anyway.

[originally from svn r6709]


--- a/loopy.c
+++ b/loopy.c
@@ -1283,7 +1283,7 @@
             break;                                                          
         case DLINE_DL:                                                  
         case DLINE_DR:                                                  
-            if (j <= (state)->h && BELOW_DOT(state, i, j) == line_old) {
+            if (j < (state)->h && BELOW_DOT(state, i, j) == line_old) {
                 LV_BELOW_DOT(state, i, j) = line_new;                   
                 retval = TRUE;
             }
@@ -1308,13 +1308,13 @@
         case DLINE_UR:                                                  
         case DLINE_DR:                                                  
         case DLINE_HORIZ:                                                  
-            if (i <= (state)->w && RIGHTOF_DOT(state, i, j) == line_old) {
+            if (i < (state)->w && RIGHTOF_DOT(state, i, j) == line_old) {
                 LV_RIGHTOF_DOT(state, i, j) = line_new;                 
                 retval = TRUE;
             }
             break;                                                          
         case DLINE_VERT:                                                  
-            if (j <= (state)->h && BELOW_DOT(state, i, j) == line_old) {
+            if (j < (state)->h && BELOW_DOT(state, i, j) == line_old) {
                 LV_BELOW_DOT(state, i, j) = line_new;                   
                 retval = TRUE;
             }