shithub: lwext4

Info  •  Files  •  Log

ext4_extent: cosmetic fixes on error code handling. Part 2.

--- a/src/ext4_extent.c

+++ b/src/ext4_extent.c

@@ -660,7 +660,7 @@

 	err = ext4_ext_dirty(inode_ref, curp);

 out:

-	if (!err && set_to_ix) {

+	if (err == EOK && set_to_ix) {

 		curp->index = ix;

 		curp->p_block = ext4_idx_pblock(ix);

 	}

@@ -988,7 +988,7 @@

 	err = ext4_ext_dirty(inode_ref, curp);

 out:

-	if (!err) {

+	if (err == EOK) {

 		curp->extent = ex;

 		curp->p_block = ext4_ext_pblock(ex);

 	}

@@ -1540,7 +1540,7 @@

 		err = ext4_ext_split_extent_at(inode_ref, ppath, split + blocks,

 					       EXT4_EXT_MARK_UNWRIT1 |

 						   EXT4_EXT_MARK_UNWRIT2);

-		if (!err) {

+		if (err == EOK) {

 			err = ext4_ext_split_extent_at(inode_ref, ppath, split,

 						       EXT4_EXT_MARK_UNWRIT1);

 		}