ref: c104f4cbdc1c34dcc121340b29aa721d95d18d05
parent: 0fe4371cc0871b713acf09fea671347ed2d4f98c
author: paulwilkins <paulwilkins@google.com>
date: Tue Feb 6 08:54:25 EST 2018
Fix file input pointer bug in allocate_gf_group_bits(). The stats input pointer, when passed in, already points to the frame after the golden frame so should not be advanced here. This fix has a small mostly positive effect on results in our test sets (tested using corpus vbr settings) and gives a gain of almost 0.5% in overall psnr (plus slightly smaller gains on other metrics) for the 4K set. The bug also caused a crash in calculate_group_score() in another patch which allows coding of slides in a slide show as a single long KF group without ARFs or GFs. Change-Id: I57a3a24baf442ce55dbc91fba05e056697c63a6f
--- a/vp9/encoder/vp9_firstpass.c
+++ b/vp9/encoder/vp9_firstpass.c
@@ -2237,9 +2237,6 @@
}
gf_group->arf_update_idx[0] = arf_buffer_indices[0];
gf_group->arf_ref_idx[0] = arf_buffer_indices[0];
-
- // Step over the golden frame / overlay frame
- if (EOF == input_stats(twopass, &frame_stats)) return;
}
// Deduct the boost bits for arf (or gf if it is not a key frame)