shithub: libvpx

Info  •  Files  •  Log  •  Branches

Fix potential integer overflow.

ioc found a potential integer overflow in the rate control.

This is related to https://code.google.com/p/webm/issues/detail?id=821

Change-Id: Ib6c4acd6e964972f932fce7490592eb134f2b7ea

--- a/vp9/encoder/vp9_ratectrl.c

+++ b/vp9/encoder/vp9_ratectrl.c

@@ -426,8 +426,8 @@

   }

   // Work out a size correction factor.

   if (projected_size_based_on_q > FRAME_OVERHEAD_BITS)

-    correction_factor = (100 * cpi->rc.projected_frame_size) /

-                            projected_size_based_on_q;

+    correction_factor = (int)((100 * (int64_t)cpi->rc.projected_frame_size) /

+                        projected_size_based_on_q);

   // More heavily damped adjustment used if we have been oscillating either side

   // of target.