shithub: libvpx

Info  •  Files  •  Log  •  Branches

googletest: enable failure on uninstantiated tests

Similar to the change in
https://aomedia-review.googlesource.com/c/aom/+/115162.
This currently is a warning, but the tree should be clean now in the
default x86-64 configuration so we can use it to prevent regressions and
find any remaining issues in other configurations.

BUG=b/159031844

Change-Id: I097537ff018668492d37164fdba5edd241dc5dbe

--- a/third_party/googletest/README.libvpx

+++ b/third_party/googletest/README.libvpx

@@ -19,3 +19,5 @@

    LICENSE

    README.md

    src

+- Enable kErrorOnUninstantiatedParameterizedTest and

+  kErrorOnUninstantiatedTypeParameterizedTest in gtest.cc

--- a/third_party/googletest/src/src/gtest.cc

+++ b/third_party/googletest/src/src/gtest.cc

@@ -414,8 +414,8 @@

 // inserted to report ether an error or a log message.

 //

 // This configuration bit will likely be removed at some point.

-constexpr bool kErrorOnUninstantiatedParameterizedTest = false;

-constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = false;

+constexpr bool kErrorOnUninstantiatedParameterizedTest = true;

+constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = true;

 // A test that fails at a given file/line location with a given message.

 class FailureTest : public Test {