ref: 3c73e587d118b8cca2de1e5436273e8b039195f7
parent: a83e1f1d53c491dd68847c84f9af4606f4da9b30
author: James Zern <jzern@google.com>
date: Thu Jul 27 21:21:28 EDT 2017
Revert "quantize ssse3: declare all variables" This reverts commit 03f5e300d69d368290305e19cc66bac8b0ea1ff8. This causes test failures under OSX: SSSE3/VP9QuantizeTest.EOBCheck/0 SSSE3/VP9QuantizeTest.OperationCheck/0 Change-Id: I122732717ead1f7af5b04c529a6948e382e5e59b
--- a/test/vp9_quantize_test.cc
+++ b/test/vp9_quantize_test.cc
@@ -381,7 +381,7 @@
// TODO(johannkoenig): SSSE3 optimizations do not yet pass these tests.
#if HAVE_SSSE3 && ARCH_X86_64
-INSTANTIATE_TEST_CASE_P(SSSE3, VP9QuantizeTest,
+INSTANTIATE_TEST_CASE_P(DISABLED_SSSE3, VP9QuantizeTest,
::testing::Values(make_tuple(&vpx_quantize_b_ssse3,
&vpx_quantize_b_c,
VPX_BITS_8)));
--- a/vpx_dsp/x86/quantize_ssse3_x86_64.asm
+++ b/vpx_dsp/x86/quantize_ssse3_x86_64.asm
@@ -15,6 +15,7 @@
SECTION .text
+; TODO(yunqingwang)fix quantize_b code for skip=1 case.
%macro QUANTIZE_FN 2
cglobal quantize_%1, 0, %2, 15, coeff, ncoeff, skip, zbin, round, quant, \
shift, qcoeff, dqcoeff, dequant, \
@@ -303,9 +304,6 @@
; skip-block, i.e. just write all zeroes
.blank:
-DEFINE_ARGS coeff, ncoeff, skip, zbin, round, quant, shift, \
- qcoeff, dqcoeff, dequant, eob, scan, iscan
-
mov r0, dqcoeffmp
movifnidn ncoeffq, ncoeffmp
mov r2, qcoeffmp