ref: 381eb3c7991dbbd0e5ae1f4c5f1fd9835d81328c
parent: b02ac73d8c543fdb04fed525d677059595e76188
author: Johann <johann.koenig@duck.com>
date: Fri Dec 7 04:28:02 EST 2018
apply -Wextra to third_party/ googletest builds cleanly with -Wextra Remove comments about webm:1069. The vp8 issue is tracked in webm:1246. Change-Id: I8bbb01d34503cc9c342f5c3aa78e9476f72b94c2
--- a/configure
+++ b/configure
@@ -614,10 +614,6 @@
check_add_cflags -Wimplicit-function-declaration
check_add_cflags -Wuninitialized
check_add_cflags -Wunused
- # -Wextra has some tricky cases. Rather than fix them all now, get the
- # flag for as many files as possible and fix the remaining issues
- # piecemeal.
- # https://bugs.chromium.org/p/webm/issues/detail?id=1069
check_add_cflags -Wextra
# check_add_cflags also adds to cxxflags. gtest does not do well with
# these flags so add them explicitly to CFLAGS only.
--- a/libs.mk
+++ b/libs.mk
@@ -112,10 +112,8 @@
CODEC_DOC_SECTIONS += decoder
endif
-# Suppress -Wextra warnings in third party code.
-$(BUILD_PFX)third_party/googletest/%.cc.o: CXXFLAGS += -Wno-missing-field-initializers
# Suppress -Wextra warnings in first party code pending investigation.
-# https://bugs.chromium.org/p/webm/issues/detail?id=1069
+# https://bugs.chromium.org/p/webm/issues/detail?id=1246
$(BUILD_PFX)vp8/encoder/onyx_if.c.o: CFLAGS += -Wno-unknown-warning-option -Wno-clobbered
$(BUILD_PFX)vp8/decoder/onyxd_if.c.o: CFLAGS += -Wno-unknown-warning-option -Wno-clobbered