shithub: qk1

Download patch

ref: 5432e05f810baa5a0d2ac75090345bba33d67d1c
parent: 8178edf7dadc13301de98099b987eefffd3adca6
author: Sigrid Solveig Haflínudóttir <sigrid@ftrv.se>
date: Wed Nov 8 21:22:29 EST 2023

Revert "R_ScanEdges: fix a wrong fixed point shift? found by clang analyzer"

This reverts commit 48aef20078bc1733bba385b94893e0eec514e93b.

Apparently even though there is an overflow, not doing it this way
may cause crashes (on ad_swampy, for example).

--- a/r_edge.c
+++ b/r_edge.c
@@ -567,7 +567,7 @@
 	edge_aftertail.prev = &edge_tail;
 
 // FIXME: do we need this now that we clamp x in r_draw.c?
-	edge_sentinel.u = 2000 << 20;		// make sure nothing sorts past this
+	edge_sentinel.u = 2000 << 24;		// make sure nothing sorts past this
 	edge_sentinel.prev = &edge_aftertail;
 
 //