shithub: pokecrystal

Download patch

ref: fa3712ea34bddfedcbc97f151cb3e6518432157c
parent: 6a5edc98e9760a9cfa63f0e8ffb6ba8747f9ff03
author: Rangi <remy.oukaour+rangi42@gmail.com>
date: Mon Nov 9 11:38:11 EST 2020

Remove "XXX" comments (various "???+" still mark unclear code)

--- a/engine/events/kurt.asm
+++ b/engine/events/kurt.asm
@@ -81,7 +81,7 @@
 	dw .MenuData
 	db 1 ; default option
 
-	db 0 ; XXX
+	db 0 ; unused
 
 .MenuData:
 	db SCROLLINGMENU_DISPLAY_ARROWS ; flags
--- a/engine/pokemon/move_mon.asm
+++ b/engine/pokemon/move_mon.asm
@@ -1815,7 +1815,7 @@
 	pop hl
 	ld de, wStringBuffer1
 	call InitName
-	ld a, $4 ; ExitAllMenus is in bank 0, XXX could this be in bank 4 in pokered?
+	ld a, $4 ; ExitAllMenus is in bank 0; maybe it used to be in bank 4
 	ld hl, ExitAllMenus
 	rst FarCall
 	ret
--- a/lib/mobile/main.asm
+++ b/lib/mobile/main.asm
@@ -8527,7 +8527,7 @@
 	ld [$cc0d], a
 	ld a, l
 	ld [$cc0c], a
-	cp $8e ; XXX LOW(MD5_K_Table + $100) ???
+	cp $8e ; LOW(MD5_K_Table + $100) ???
 	jp nz, .asm_113751
 	ld de, $cc18
 	ld hl, $cbe7
--- a/mobile/mobile_41.asm
+++ b/mobile/mobile_41.asm
@@ -1021,7 +1021,7 @@
 	call Get2bpp
 	ld de, $40b0
 	ld hl, vTiles2 tile $6b
-	ld b, $0f ; XXX no graphics at 0f:40b0
+	ld b, $0f ; no graphics at 0f:40b0; JP leftover???
 	call Get2bpp
 	farcall LoadFrame
 	ret