shithub: pokecrystal

Download patch

ref: 9b4ebe940023ef346593db9612ab29fc522eb767
parent: 9aac39bebc6fbb1f7442e9efadf88e2bfcd13a01
author: Idain <luiscarlosholguinperez@outlook.com>
date: Sun Mar 20 15:58:18 EDT 2022

Replace magic numbers with constants (#894)


--- a/engine/pokemon/move_mon.asm
+++ b/engine/pokemon/move_mon.asm
@@ -864,7 +864,7 @@
 	add hl, bc
 	ld d, h
 	ld e, l
-	ld hl, $a
+	ld hl, MON_EXP + 2
 	add hl, bc
 	push bc
 	ld b, TRUE
@@ -887,7 +887,7 @@
 	ld d, a
 	callfar CalcExpAtLevel
 	pop bc
-	ld hl, $8
+	ld hl, MON_EXP
 	add hl, bc
 	ldh a, [hMultiplicand]
 	ld [hli], a
@@ -1009,7 +1009,7 @@
 
 	; Set all 5 Experience Values to 0
 	xor a
-	ld b, 2 * 5
+	ld b, 2 * NUM_EXP_STATS
 .loop2
 	ld [de], a
 	inc de