shithub: pokecrystal

Download patch

ref: 42118869210450c9ca02ddc90460461008824701
parent: 2cf6dc1e0cb3b349bca41a47b68d563418fedefc
author: Rangi <remy.oukaour+rangi42@gmail.com>
date: Sun Nov 3 09:15:20 EST 2019

Use constants for quantities when copying SGB border tiles and palettes

--- a/engine/gfx/color.asm
+++ b/engine/gfx/color.asm
@@ -1075,21 +1075,21 @@
 	ld a, $e4
 	ldh [rBGP], a
 	ld de, vTiles1
-	ld bc, 20 tiles
+	ld bc, (6 + SCREEN_WIDTH + 6) * 5 * 2
 	call CopyData
-	ld b, 18
+	ld b, SCREEN_HEIGHT
 .loop
 	push bc
-	ld bc, $c
+	ld bc, 6 * 2
 	call CopyData
-	ld bc, $28
+	ld bc, SCREEN_WIDTH * 2
 	call ClearBytes
-	ld bc, $c
+	ld bc, 6 * 2
 	call CopyData
 	pop bc
 	dec b
 	jr nz, .loop
-	ld bc, $140
+	ld bc, (6 + SCREEN_WIDTH + 6) * 5 * 2
 	call CopyData
 	ld bc, $100
 	call ClearBytes
@@ -1195,6 +1195,7 @@
 INCBIN "gfx/sgb/sgb_border.bin"
 
 SGBBorderPalettes:
+; assumed to come after SGBBorderMap
 INCLUDE "gfx/sgb/sgb_border.pal"
 
 SGBBorder: