ref: 25794633f193e46a7844ea065c5932ec6e11765e
parent: 62fccbbd99ce8c4de44fe658f6247468d192e81d
parent: c3f389d6156cb573c6105059beba67ff0a72d30a
author: mid-kid <esteve.varela@gmail.com>
date: Sun Feb 23 19:58:44 EST 2020
Merge pull request #688 from Rangi42/master Edit some comments about bad code
--- a/engine/items/switch_items.asm
+++ b/engine/items/switch_items.asm
@@ -225,7 +225,6 @@
ret
ItemSwitch_ConvertItemFormatToDW:
-; This function is absolutely idiotic.
push hl
ld a, [wMenuData_ScrollingMenuItemFormat]
ld c, a
--- a/engine/menus/init_gender.asm
+++ b/engine/menus/init_gender.asm
@@ -10,12 +10,11 @@
ld [wd478], a
ld [wd002], a
ld [wd003], a
- ; could have done "ld a, [wd479] \ and %11111100", saved four operations
ld a, [wd479]
- res 0, a
+ res 0, a ; ???
ld [wd479], a
ld a, [wd479]
- res 1, a
+ res 1, a ; ???
ld [wd479], a
ret
--- a/engine/overworld/player_object.asm
+++ b/engine/overworld/player_object.asm
@@ -122,9 +122,10 @@
ld hl, wPlayerLastMapY
ld [hl], e
ld e, a
+; the next three lines are useless
ld a, [wObjectFollow_Leader]
cp $0
- ret nz ; wtf
+ ret nz
ret
CopyObjectStruct::
--- a/engine/phone/phone.asm
+++ b/engine/phone/phone.asm
@@ -23,7 +23,7 @@
ret
CheckCellNum::
- jp _CheckCellNum ; wtf
+ jp _CheckCellNum ; useless
_CheckCellNum:
ld hl, wPhoneList
--- a/engine/pokemon/stats_screen.asm
+++ b/engine/pokemon/stats_screen.asm
@@ -60,7 +60,7 @@
StatsScreenMain:
xor a
ld [wJumptableIndex], a
- ; stupid interns
+; ???
ld [wcf64], a
ld a, [wcf64]
and %11111100
@@ -80,7 +80,7 @@
StatsScreenMobile:
xor a
ld [wJumptableIndex], a
- ; stupid interns
+; ???
ld [wcf64], a
ld a, [wcf64]
and %11111100
--- a/home/map.asm
+++ b/home/map.asm
@@ -592,7 +592,7 @@
jr z, .skip
; jr c, .skip
-; stupid waste of time and space
+ ; could have done "inc hl" instead
ld bc, 1
add hl, bc
; Fill the remaining sprite IDs and y coords with 0 and -1, respectively.
--- a/mobile/mobile_40.asm
+++ b/mobile/mobile_40.asm
@@ -6469,7 +6469,7 @@
jr .okay
.link_battle
-; this is idiotic
+; the next three operations are pointless
hlcoord 3, 10
ld b, 1
ld c, 11
--- a/mobile/mobile_menu.asm
+++ b/mobile/mobile_menu.asm
@@ -146,7 +146,7 @@
ld [hli], a
ld a, $20 ; w2DMenuCursorOffsets
ld [hli], a
- ; this is a stupid way to load $c3
+ ; could have done "ld a, A_BUTTON | D_UP | D_DOWN | B_BUTTON" instead
ld a, A_BUTTON
add D_UP
add D_DOWN
--
⑨