shithub: libmujs

Info  •  Files  •  Log  •  Branches

Use memcpy instead of strcpy when copying short strings.

--- a/jsrun.c

+++ b/jsrun.c

@@ -107,7 +107,8 @@

 	CHECKSTACK(1);

 	if (n < 16) {

 		STACK[TOP].type = JS_TSHRSTR;

-		strcpy(STACK[TOP].u.shrstr, v);

+		memcpy(STACK[TOP].u.shrstr, v, n);

+		STACK[TOP].u.shrstr[n] = 0;

 	} else {

 		STACK[TOP].type = JS_TMEMSTR;

 		STACK[TOP].u.memstr = jsV_newmemstring(J, v, n);

--- a/jsvalue.c

+++ b/jsvalue.c

@@ -284,7 +284,8 @@

 			int n = strlen(p);

 			if (n < 16) {

 				v->type = JS_TSHRSTR;

-				strcpy(v->u.shrstr, p);

+				memcpy(v->u.shrstr, p, n);

+				v->u.shrstr[n] = 0;

 				return v->u.shrstr;

 			} else {

 				v->type = JS_TMEMSTR;