shithub: libvpx

Download patch

ref: f33f2fc686c5a248765211f570bca1dfa6a8c44b
parent: b78d3b21e336e9b08f0208f9a998aa804759a7f9
author: James Zern <jzern@google.com>
date: Fri Jan 17 18:33:35 EST 2020

vpx_timestamp,gcd: assert params are positive

this function is currently only used with range checked timestamp
values, but this documents the function's expectations in case it's used
elsewhere

Change-Id: I9de314fc500a49f34f8a1df3598d64bc5070248e

--- a/vpx_util/vpx_timestamp.h
+++ b/vpx_util/vpx_timestamp.h
@@ -11,6 +11,8 @@
 #ifndef VPX_VPX_UTIL_VPX_TIMESTAMP_H_
 #define VPX_VPX_UTIL_VPX_TIMESTAMP_H_
 
+#include <assert.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif  // __cplusplus
@@ -23,7 +25,9 @@
 
 static INLINE int gcd(int64_t a, int b) {
   int r;  // remainder
-  while (b > 0) {
+  assert(a >= 0);
+  assert(b > 0);
+  while (b != 0) {
     r = (int)(a % b);
     a = b;
     b = r;