shithub: libvpx

Download patch

ref: 1647d0c62c565c9bbe7ba7d993418a2f1185ca71
parent: b120ba5781a520c015b356a7c77c89545ccdee32
author: Wan-Teh Chang <wtc@google.com>
date: Mon May 4 07:18:22 EDT 2020

Remove unneeded null check for entry in for loop

In vpx_codec_control_(), before we enter the for loop, we have already
checked if ctx->iface->ctrl_maps is null and handle that as an error. So
the for loop can assume ctx->iface->ctrl_maps is not null, which implies
'entry' is not null (both initially and after entry++).

Change-Id: Ieafe464d4111fdb77f0586ecfa1835d1cfd44d94

--- a/vpx/src/vpx_codec.c
+++ b/vpx/src/vpx_codec.c
@@ -97,7 +97,7 @@
 
     res = VPX_CODEC_INCAPABLE;
 
-    for (entry = ctx->iface->ctrl_maps; entry && entry->fn; entry++) {
+    for (entry = ctx->iface->ctrl_maps; entry->fn; entry++) {
       if (!entry->ctrl_id || entry->ctrl_id == ctrl_id) {
         va_list ap;