shithub: opus

Download patch

ref: f94bd54302d4b67f7035e11598f07dc8caa0c26b
parent: 115edd9c0668ad07d9be1e4ea150689a4c32508a
author: Jean-Marc Valin <jmvalin@amazon.com>
date: Mon Jun 26 22:56:49 EDT 2023

Handle the sign of the DRED offset

--- a/silk/dred_decoder.c
+++ b/silk/dred_decoder.c
@@ -36,9 +36,13 @@
 #include "dred_coding.h"
 #include "celt/entdec.h"
 
+/* From http://graphics.stanford.edu/~seander/bithacks.html#FixedSignExtend */
+static int sign_extend(int x, int b) {
+  int m = 1U << (b - 1);
+  return (x ^ m) - m;
+}
 
 
-
 int dred_ec_decode(OpusDRED *dec, const opus_uint8 *bytes, int num_bytes, int min_feature_frames)
 {
   const opus_uint16 *p0              = DRED_rdovae_get_p0_pointer();
@@ -57,7 +61,7 @@
 
   /* decode initial state and initialize RDOVAE decoder */
   ec_dec_init(&ec, (unsigned char*)bytes, num_bytes);
-  dec->dred_offset = ec_dec_uint(&ec, 32);
+  dec->dred_offset = sign_extend(ec_dec_uint(&ec, 32), 5);
   q0 = ec_dec_uint(&ec, 16);
   dQ = ec_dec_uint(&ec, 8);
   /*printf("%d %d %d\n", dred_offset, q0, dQ);*/
--