shithub: neoventi

Info  •  Files  •  Log  •  Branches

disk: remove needless allocation/free in the index access path

--- a/disk.c

+++ b/disk.c

@@ -72,15 +72,12 @@

 int

 vtreadlookup(u8int *score, VtAddress *addr)

 {

-	u8int *buf;

+	u8int buf[0x2000];

 	u16int entry;

 	u64int aindex;

 	u64int bucket = U32GET(score) / index.div;

 	VtISect *s_sect = &index.sects[isectforbucket(bucket)];

 	bucket -= s_sect->start;

-	buf = malloc(s_sect->blocksize);

-	if(buf == nil)

-		sysfatal("OOM, blocksize: %d", s_sect->blocksize);

 	if(pread(s_sect->fd, (char*)buf, s_sect->blocksize, s_sect->blockbase + (bucket << s_sect->blocklog)) != s_sect->blocksize)

 		sysfatal("Failed to read bucket");

 	if(s_sect->bucketmagic && U32GET(buf + 2) != s_sect->bucketmagic)

@@ -93,7 +90,6 @@

 	aindex = aindexfromaddr(addr->offset);

 	addr->s_arena = arenafromindex(aindex);

 	addr->offset -= index.amap[aindex].start;

-	free(buf);

 	return 1;

 }